Skip to content

Conversation

@bilgeyucel
Copy link
Contributor

No description provided.

@bilgeyucel bilgeyucel requested a review from julian-risch May 31, 2025 19:57
@bilgeyucel bilgeyucel self-assigned this May 31, 2025
@bilgeyucel bilgeyucel requested a review from a team as a code owner May 31, 2025 19:57
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe only very few users have access to a Notion API key and would be willing to enter it in this tutorial with write access to their Notion. Running the tutorial also worked for me when just entering "key" in the getpass input field.
I suggest we mention in the beginning of the tutorial that users can also run it without a Notion API key by leaving it empty if that works too.
Have you tried Duckduckgo? Did you run into rate limits? If not, we could think about making it the default or at least automatically switching to it if the user doesn't enter a SerperDev key

By the way, there is a prompt Save the this text on Notion: that we should update.

@bilgeyucel
Copy link
Contributor Author

bilgeyucel commented Jun 2, 2025

I believe only very few users have access to a Notion API key and would be willing to enter it in this tutorial with write access to their Notion. Running the tutorial also worked for me when just entering "key" in the getpass input field. I suggest we mention in the beginning of the tutorial that users can also run it without a Notion API key by leaving it empty if that works too. Have you tried Duckduckgo? Did you run into rate limits? If not, we could think about making it the default or at least automatically switching to it if the user doesn't enter a SerperDev key

By the way, there is a prompt Save the this text on Notion: that we should update.

@julian-risch, I made the DuckDuckGo search component the default one and suggested using SerperDevWebSearch if users hit the rate limit. And yes, I hit the rate limit a couple of times, but for users, it won't happen (hopefully) if they don't run the notebook more than once or twice.

Regarding notion, no, it doesn't work without the proper API key; it just doesn't throw an error, as the Notion API doesn't make this check until we send a request to create a page. It just returns a response with success:False
image

You have a point about providing the notion access, but users need to give the page ID and limit the page to which this component has access. Either way, users are free not to use the notion tool in their agent, but this tutorial provides nice guidance for those who want to. That's why I marked this tutorial as "advanced"

@bilgeyucel bilgeyucel requested a review from julian-risch June 2, 2025 14:33
@bilgeyucel bilgeyucel merged commit 47c7205 into main Jun 9, 2025
2 of 4 checks passed
@bilgeyucel bilgeyucel deleted the multi-agent-tutorial branch June 9, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

None yet

3 participants